Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summaries for machine learning APIs #2453

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Add summaries for machine learning APIs #2453

merged 2 commits into from
Jul 4, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 14, 2024

Relates to #2635

This PR fixes the operation summaries for a handful of machine learning anomaly detection APIs (ending period is necessary per https://github.com/elastic/elasticsearch-specification/blob/main/docs/doc-comments-guide.md), then runs the make generate and make transform-to-openapi commands to refresh the output.

@lcawl lcawl requested a review from swallez March 14, 2024 00:22
@lcawl lcawl marked this pull request as ready for review March 14, 2024 15:09
@lcawl lcawl requested review from a team as code owners March 14, 2024 15:09
@lcawl lcawl marked this pull request as draft May 9, 2024 14:52
@lcawl lcawl requested review from szabosteve and removed request for a team and swallez July 3, 2024 22:39
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.close_job 🟢 64/64 63/63
ml.delete_job 🟢 47/47 47/47
ml.open_job 🟢 83/83 83/83
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review July 3, 2024 22:39
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lcawl lcawl merged commit 5fbb80f into main Jul 4, 2024
6 checks passed
@lcawl lcawl deleted the ml-summaries branch July 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants